fix: address all 10 code-review findings #15

Closed

gabrielgad wants to merge 7 commits from split/review-fixes into split/cleanup

gabrielgad commented

2026-06-30 15:37:07 -04:00

(Migrated from github.com)

From a high-effort multi-agent review of the branch — all 10 verified findings resolved.

Crashes / data loss: clear_tmp() reaps only dead-pid orphan scratch (no longer rm-rf's through a concurrent live session's overlay into player saves); has_steamstub_elf() bounds-checks the ELF offset instead of panicking.
Launch correctness: no_gamescope gated on the resolved seat list (matching build_cmds) not inst.together; Keen skips its launch arg when the emu binary is absent.
Concurrency isolation: standalone overlay + Keen data file namespaced per-launch; same-profile instances get distinct Proton prefixes.
Layout: fullscreen always honors the assigned monitor (never auto-spreads onto a virtual Sunshine output → wedge); tiling indexes the original window snapshot; Grid honors window_count.

Builds, 0 clippy warnings, 153 tests pass.

From a high-effort multi-agent review of the branch — all 10 verified findings resolved. **Crashes / data loss:** `clear_tmp()` reaps only dead-pid orphan scratch (no longer rm-rf's through a concurrent live session's overlay into player saves); `has_steamstub_elf()` bounds-checks the ELF offset instead of panicking. **Launch correctness:** `no_gamescope` gated on the resolved seat list (matching `build_cmds`) not `inst.together`; Keen skips its launch arg when the emu binary is absent. **Concurrency isolation:** standalone overlay + Keen data file namespaced per-launch; same-profile instances get distinct Proton prefixes. **Layout:** fullscreen always honors the assigned monitor (never auto-spreads onto a virtual Sunshine output → wedge); tiling indexes the original window snapshot; Grid honors `window_count`. Builds, 0 clippy warnings, 153 tests pass.

gabrielgad commented

2026-07-03 16:21:19 -04:00

(Migrated from github.com)

Landed via fast-forward merge to main (671e113) - only remaining delta was the CI runner label change, no conflicts.

Landed via fast-forward merge to main (671e113) - only remaining delta was the CI runner label change, no conflicts.