fix(sidebar): a viewed pane's tab and workspace read ready #21

Closed

gabrielgad wants to merge 1 commit from fix/tab-status-follows-seen-panes into fix/done-reads-idle-when-opened

pull from: fix/tab-status-follows-seen-panes

merge into: gabrielgad:fix/done-reads-idle-when-opened

gabrielgad:main

gabrielgad:gabeforge

gabrielgad:feat/herdr-keymap

gabrielgad:deploy

gabrielgad:live

gabrielgad:feat/composer-pill-picker

gabrielgad:contrib/base

Conversation 1 Commits 1 Files changed 5 +93 -6

gabrielgad commented 2026-10-08 13:20:19 -04:00

Owner

Copy link

Change

herdr's tab and workspace status is its roll-up of their panes. Where the bridge rewrites a pane (a viewed done reads idle), the tab kept done. rollUp in server/viewed-panes.ts recomputes them for the touched panes (blocked > working > done > idle). A re-reported done on a viewed pane now counts as seen.

Validation

bun run check fast passes. Unit tests cover seen plus working, seen only, rank and untouched tabs. The #10 contract test now checks the session's tab status and fails without the fix. Screenshots 412x900: the tab's Done dot stays before, clears after.

## Change herdr's tab and workspace status is its roll-up of their panes. Where the bridge rewrites a pane (a viewed done reads idle), the tab kept done. `rollUp` in `server/viewed-panes.ts` recomputes them for the touched panes (blocked > working > done > idle). A re-reported done on a viewed pane now counts as seen. ## Validation `bun run check fast` passes. Unit tests cover seen plus working, seen only, rank and untouched tabs. The #10 contract test now checks the session's tab status and fails without the fix. Screenshots 412x900: the tab's Done dot stays before, clears after.

rollup-before-viewed-412x900.png

18 KiB

rollup-after-viewed-412x900.png

17 KiB

gabrielgad added 1 commit 2026-10-08 13:20:19 -04:00

fix(sidebar): a viewed pane's tab and workspace read ready ... 9aeb7d50f4

A tab's and workspace's status is herdr's roll-up of its panes. Recompute it for those holding a pane rewritten here, and count a re-reported done on a viewed pane as seen.

gabrielgad commented 2026-10-08 13:20:23 -04:00

Author

Owner

Copy link

Before (tab opened, dot stays Done):

After (dot clears):

Before (tab opened, dot stays Done):  After (dot clears): 

gabrielgad closed this pull request 2026-10-22 14:57:24 -04:00

Some checks failed

Hide all checks

CI / Native Windows install (pull_request) Has been cancelled

Details

CI / Fast checks (pull_request) Has been cancelled

Details

CI / Integration and browser (pull_request) Has been cancelled

Details

Remote PC bundles / bundle (macos-15) (pull_request) Has been cancelled

Details

Remote PC bundles / bundle (macos-15-intel) (pull_request) Has been cancelled

Details

Remote PC bundles / bundle (ubuntu-24.04) (pull_request) Has been cancelled

Details

Remote PC bundles / bundle (ubuntu-24.04-arm) (pull_request) Has been cancelled

Details

Remote PC bundles / bundle-windows (pull_request) Has been cancelled

Details

Remote PC bundles / ssh (pull_request) Has been cancelled

Details

Remote PC bundles / smoke-windows (pull_request) Has been cancelled

Details

Remote PC bundles / release (pull_request) Has been cancelled

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

gabrielgad/ovis-web-ui!21

No description provided.